[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

Mon Jul 3 00:42:03 PDT 2023

DavidSpickett added a comment.

Good to see progress on this. A few things.

1. I will add an extra container on Linaro's side for this if/when this lands and has been stable on the existing containers for a bit.

2. This would in theory build on either 32 bit or 64 bit. Using the latter only makes sense, closer to developer machines, fewer configurations to go wrong (so there's no need to change any tags here).

3. Our containers have an unusual compiler setup that allows us to ccache between them. We have clang-15 installed from the llvm releases and use a shim in `/usr/local/bin/cc` to call that compiler. The result is that `clang`, `llvm-ar`, `llvm-as` etc, are actually 10.0.0 from the base image (that's also why ld.lld isn't being found right now, though we do have lld 15 in the container).

I suggest that for now, `CMAKE_C(XX)_COMPILER` need not be set as it will find `cc` and `c++` from `/usr/local/bin`. The rest of the tools I can add symlinks in the same place so that the 15.0.0 versions are picked up.

Let me know when it makes sense for me to try this locally and I'll get that done. Once the containers are updated you'll be able to get a green build here before landing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246