[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks a lot for working on this!



================
Comment at: libcxx/utils/ci/run-buildbot:608
+    clean
+    ${MONOREPO_ROOT}/libcxx/utils/ci/build-picolibc.sh \
+        --build-dir "${BUILD_DIR}" \
----------------
Why do we need to build picolib every CI run instead of storing it in the base image?
If that is really needed we should add some documentation why it's needed.


================
Comment at: libcxx/utils/ci/run-buildbot:615-616
+          -DCMAKE_CXX_FLAGS="${flags}" \
+          -DCMAKE_C_COMPILER=clang \
+          -DCMAKE_CXX_COMPILER=clang++ \
+          -DLIBCXX_ENABLE_WERROR=NO
----------------
philnik wrote:
> These should be set through the environment variable and not be hard-coded.
+1
Also do we need to C compiler at all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246