[libcxx-commits] [PATCH] D142588: [libc++] Remove use of internal glibc macros to determine if c8rtomb() and mbrtoc8() are present

Thu Jan 26 14:25:50 PST 2023

tahonermann added a comment.

Thanks @ldionne, I'm heading out of town for the weekend, so I'll wait to push this until Monday.

I meant to get this in before the Clang 16 branch, but life and stuff. I'll file an issue to cherry-pick the change for the release branch once committed. Please let me know if you have any thoughts on that.

================
Comment at: libcxx/include/__config:1223
 // functions are declared by the C library.
 #  define _LIBCPP_HAS_NO_C8RTOMB_MBRTOC8
----------------
ldionne wrote:
> Nitpick, but when you upload your patches, please consider using `arc diff` so that context is available in the diffs!
Oops, I forgot the `-U99999` option when generating the diff.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142588/new/

https://reviews.llvm.org/D142588