[libcxx-commits] [PATCH] D142588: [libc++] Remove use of internal glibc macros to determine if c8rtomb() and mbrtoc8() are present

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 26 14:17:57 PST 2023


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

TBH this seems reasonable to me. If this seems reasonable to you, I'll go with your judgement here.



================
Comment at: libcxx/include/__config:1223
 // functions are declared by the C library.
 #  define _LIBCPP_HAS_NO_C8RTOMB_MBRTOC8
----------------
Nitpick, but when you upload your patches, please consider using `arc diff` so that context is available in the diffs!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142588/new/

https://reviews.llvm.org/D142588



More information about the libcxx-commits mailing list