[libcxx-commits] [PATCH] D142180: [libc++] Enforce formatting for already formatted and new files and ignore the formatting of tests

[Hui via Phabricator via libcxx-commits]

huixie90 added a comment.

In D142180#4069287 <https://reviews.llvm.org/D142180#4069287>, @Mordante wrote:

> From a personal perspective I'm very unhappy with this patch, I really would like to use clang-format in most (all) of our code. From I libc++ developer perspective I agree we need to do this. I think more people need to have a look at it, therefore I will leave the final approval to others.

I think we all agree that we want clang-format for all of our code. The problem now is that it is not the case at the moment. And the format CI is always failing and everyone ignores it. I think this patch at least is a step forward to enforce the formatting. However, this is still very challenging as people have different versions of clang-format. I wonder if we could


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142180/new/

https://reviews.llvm.org/D142180