[libcxx-commits] [PATCH] D142180: [libc++] Enforce formatting for already formatted and new files and ignore the formatting of tests

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

>From a personal perspective I'm very unhappy with this patch, I really would like to use clang-format in most (all) of our code. From I libc++ developer perspective I agree we need to do this. I think more people need to have a look at it, therefore I will leave the final approval to others.



================
Comment at: libcxx/utils/generate_ignore_format.sh:2
+
+rm libcxx/utils/data/ignore_format.txt
+for file in $(find libcxx/{benchmarks,include,src}/ -type f); do
----------------
This file needs a shebang and I would like comment what it does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142180/new/

https://reviews.llvm.org/D142180