[libcxx-commits] [PATCH] D141882: [libc++] Remove #pragma GCC system_header

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D141882#4060005 <https://reviews.llvm.org/D141882#4060005>, @Mordante wrote:

> It seems the CI disagrees and they are needed for some headers since they use implementation reserved things, for example
> `_LIBCPP_HIDE_FROM_ABI constexpr chrono::hours operator""h(unsigned long long __h)`

The problem is that libc++abi doesn't use `-isystem` when including libc++ headers. I wasn't able to find out how libc++abi actually includes the libc++ headers though. Maybe Louis can help me out there.

> I think if we want to do this we should mention this change to vendors.
>
> Since we're quite close to the branching of LLVM 16 I would prefer to postpone this patch by a week, unless there are pressing reasons to land this before branching.

I'm fine with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141882/new/

https://reviews.llvm.org/D141882