[libcxx-commits] [PATCH] D141882: [libc++] Remove #pragma GCC system_header

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 17 11:58:50 PST 2023


Mordante added a comment.

It seems the CI disagrees and they are needed for some headers since they use implementation reserved things, for example
`_LIBCPP_HIDE_FROM_ABI constexpr chrono::hours operator""h(unsigned long long __h)`

I think if we want to do this we should mention this change to vendors.

Since we're quite close to the branching of LLVM 16 I would prefer to postpone this patch by a week, unless there are pressing reasons to land this before branching.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141882/new/

https://reviews.llvm.org/D141882



More information about the libcxx-commits mailing list