[libcxx-commits] [PATCH] D141885: [libc++] Add ALLOW_RETRIES to a few flaky tests

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 17 13:11:28 PST 2023


philnik updated this revision to Diff 489929.
philnik marked an inline comment as done.
philnik added a comment.

Address comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141885/new/

https://reviews.llvm.org/D141885

Files:
  libcxx/test/std/thread/futures/futures.async/async.pass.cpp
  libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_shared_for.pass.cpp


Index: libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_shared_for.pass.cpp
===================================================================
--- libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_shared_for.pass.cpp
+++ libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_shared_for.pass.cpp
@@ -9,7 +9,7 @@
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03, c++11
 
-// ALLOW_RETRIES: 2
+// ALLOW_RETRIES: 3
 
 // shared_timed_mutex was introduced in macosx10.12
 // UNSUPPORTED: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11}}
Index: libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp
===================================================================
--- libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp
+++ libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp
@@ -8,6 +8,8 @@
 //
 // UNSUPPORTED: no-threads
 
+// ALLOW_RETRIES: 3
+
 // notify_all_at_thread_exit(...) requires move semantics to transfer the unique_lock.
 // UNSUPPORTED: c++03
 
Index: libcxx/test/std/thread/futures/futures.async/async.pass.cpp
===================================================================
--- libcxx/test/std/thread/futures/futures.async/async.pass.cpp
+++ libcxx/test/std/thread/futures/futures.async/async.pass.cpp
@@ -9,6 +9,8 @@
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03
 
+// ALLOW_RETRIES: 3
+
 // <future>
 
 // template <class F, class... Args>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141885.489929.patch
Type: text/x-patch
Size: 1736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230117/617d4e2a/attachment.bin>


More information about the libcxx-commits mailing list