[libcxx-commits] [PATCH] D141885: [libc++] Add ALLOW_RETRIES to a few flaky tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.pass.cpp:1-2
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
----------------
This one is not flaky, it's simply too slow. I would instead split it up.

I'd rather not use `ALLOW_RETRIES` since that isn't what it was meant for -- it was meant to help with tests that are inherently timing-sensitive, not with tests that are just too slow. For example, if `ranges.transform.pass.cpp` were to fail due to a legitimate problem in the code, it wouldn't make sense to retry it 3 times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141885/new/

https://reviews.llvm.org/D141885