[libcxx-commits] [PATCH] D141812: [libc++] Introduce _LIBCPP_HIDE_FROM_ABI_NAMESPACE_STD

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D141812#4058098 <https://reviews.llvm.org/D141812#4058098>, @huixie90 wrote:

> With regard to gcc's `always_inline`, since we are using  `_LIBCPP_HIDE_FROM_ABI ` everywhere now, would it cause this problem to gcc?
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104719#c10

I don't know if it errors out at any point, but code bloat at `-O0` is definitely a problem.



================
Comment at: libcxx/test/tools/clang_tidy_checks/hide_from_abi.cpp:16
+bool is_hide_from_abi_namespace(std::string_view str) {
+  return str.size() == strlen("__MAMIPA") && str.starts_with("__");
+}
----------------
Mordante wrote:
> `__MAMIPA`? 
major, minor, patch. Do you have a better suggestion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141812/new/

https://reviews.llvm.org/D141812