[libcxx-commits] [PATCH] D144915: [libc++] Fix modules issues on OS X

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 28 10:48:46 PST 2023


philnik added a comment.

We could rename it to `types` or something similar. It would actually also make sense to put stuff like `MoveOnly`, `input_iterator` etc. inside there. Then we'd have `types::for_each(types::integral_types{}, ...)`. WDYT?

Could we maybe get a modules build on macOS, since it seems there are some pretty horrible things inside the system headers? Who thought it would be a good idea to reserve `Point`? I think Android has a few horrific things in the system headers too, but there we don't have any CI currently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144915/new/

https://reviews.llvm.org/D144915



More information about the libcxx-commits mailing list