[libcxx-commits] [PATCH] D144913: [libc++] Refactor allocator_mismatch.compile.fail.cpp -> .verify.cpp

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 27 14:12:33 PST 2023


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % comment.



================
Comment at: libcxx/test/std/containers/associative/map/allocator_mismatch.verify.cpp:15
+std::map<int, int, std::less<int>, std::allocator<long> > m;
+  // expected-error-re at map:* {{static assertion failed {{.*}}: Allocator::value_type must be same type as value_type}}
----------------
Let's not use the header name. That will just result in unnecessary refactorings later and doesn't really have any value compared to a generic match. It's not like we actually care from what header the error message is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144913/new/

https://reviews.llvm.org/D144913



More information about the libcxx-commits mailing list