[libcxx-commits] [PATCH] D144913: [libc++] Refactor allocator_mismatch.compile.fail.cpp -> .verify.cpp

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 27 13:56:44 PST 2023


ldionne created this revision.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

compile.fail.cpp tests are an anti-feature since they are too easy to
break when evolving code. This patch moves various allocator_mismatch
tests to .verify.cpp and normalizes the error messages from various
containers.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144913

Files:
  libcxx/include/forward_list
  libcxx/include/list
  libcxx/include/unordered_map
  libcxx/include/unordered_set
  libcxx/test/std/containers/associative/map/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/associative/map/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/associative/multimap/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/associative/multimap/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/associative/multiset/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/associative/multiset/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/associative/set/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/associative/set/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/associative/set/range_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/sequences/deque/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/sequences/deque/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/sequences/forwardlist/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/sequences/forwardlist/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/sequences/list/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/sequences/list/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/sequences/vector/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/sequences/vector/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/unord/unord.map/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/unord/unord.map/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/unord/unord.multimap/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/unord/unord.multimap/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/unord/unord.multiset/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/unord/unord.multiset/allocator_mismatch.verify.cpp
  libcxx/test/std/containers/unord/unord.set/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/containers/unord/unord.set/allocator_mismatch.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144913.500901.patch
Type: text/x-patch
Size: 13881 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230227/ce5e47f1/attachment-0001.bin>


More information about the libcxx-commits mailing list