[libcxx-commits] [PATCH] D144126: [libc++] Improve the format ignorelist generation.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 17 08:49:37 PST 2023


Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review.



================
Comment at: libcxx/utils/generate_ignore_format.sh:16
+for file in $(find libcxx/{benchmarks,include,src}/ -type f -not -name '*.*' -or \( \
+	 -name "*.h" -or -name "*.hh" -or -name "*.hpp" -or -name "*.hxx" -or \
+	 -name "*.c" -or -name "*.cc" -or -name "*.cpp" -or -name "*.cxx" -or \
----------------
philnik wrote:
> AFAIK we don't have most of these file endings. IMO we shouldn't list them here (and remove them from `check-format`).
`*.c` is unused, but I'm want to keep it.
`*.hh`, `*.hxx`, `*.cc`, and `*.cxx` are unused and these I'll remove.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144126/new/

https://reviews.llvm.org/D144126



More information about the libcxx-commits mailing list