[libcxx-commits] [PATCH] D144126: [libc++] Improve the format ignorelist generation.

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 16 13:26:59 PST 2023


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % comment. Thanks for improving the script.



================
Comment at: libcxx/utils/generate_ignore_format.sh:16
+for file in $(find libcxx/{benchmarks,include,src}/ -type f -not -name '*.*' -or \( \
+	 -name "*.h" -or -name "*.hh" -or -name "*.hpp" -or -name "*.hxx" -or \
+	 -name "*.c" -or -name "*.cc" -or -name "*.cpp" -or -name "*.cxx" -or \
----------------
AFAIK we don't have most of these file endings. IMO we shouldn't list them here (and remove them from `check-format`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144126/new/

https://reviews.llvm.org/D144126



More information about the libcxx-commits mailing list