[libcxx-commits] [PATCH] D143962: [libc++][NFC] Replace _LIBCPP_STD_VER > x with _LIBCPP_STD_VER >= x

Wed Feb 15 12:50:06 PST 2023

ldionne added a comment.

In D143962#4129268 <https://reviews.llvm.org/D143962#4129268>, @Mordante wrote:

> In D143962#4124621 <https://reviews.llvm.org/D143962#4124621>, @var-const wrote:
>
>> LGTM, but I'll leave the approval to @ldionne (I remember this was discussed before and want to make sure this reflects the final decision; personally, I fully support this and think it's long overdue).
>
> AFAIK we never made a decision :-(
>
> I really would like to discuss this upfront instead of rushing it in. I expect merge conflicts in is some of my formatting patches. Not hard to fix, but it's quite annoying.

Mark and I talked about this offline. So my recollection is that we did have a discussion at some point on a review (or on Discord) where we had agreed to do this. I think I was initially against but had ended up agreeing since most folks wanted to do it. Clearly, this wasn't unanimous.

Mark and I agreed to set up an infrequent meeting with regular libc++ contributors to discuss these sorts of broad "policy" decisions in the future to make sure we had a clear agreement on those beforehand. We would take a few notes and publish them to Discourse or add them to a design document of sorts in the repository, making sure that those decisions are recorded somewhere.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143962/new/

https://reviews.llvm.org/D143962