[libcxx-commits] [PATCH] D143962: [libc++][NFC] Replace _LIBCPP_STD_VER > x with _LIBCPP_STD_VER >= x

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 15 08:14:32 PST 2023


Mordante added a comment.

In D143962#4124621 <https://reviews.llvm.org/D143962#4124621>, @var-const wrote:

> LGTM, but I'll leave the approval to @ldionne (I remember this was discussed before and want to make sure this reflects the final decision; personally, I fully support this and think it's long overdue).

AFAIK we never made a decision :-(

I really would like to discuss this upfront instead of rushing it in. I expect merge conflicts in is some of my formatting patches. Not hard to fix, but it's quite annoying.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143962/new/

https://reviews.llvm.org/D143962



More information about the libcxx-commits mailing list