[libcxx-commits] [PATCH] D143962: [libc++][NFC] Replace _LIBCPP_STD_VER > x with _LIBCPP_STD_VER >= x

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:286
     "headers": ["new"],
     "test_suite_guard": "TEST_STD_VER > 17 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L",
+    "libcxx_guard": "_LIBCPP_STD_VER >= 20 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L",
----------------
jloser wrote:
> Out of curiosity, did we decide (or should we) to do the same for `TEST_STD_VER`?  It seems slightly out of place seeing it use `>`.  WDYT?
I agree, however that touches even more files. Let's do it separately if at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143962/new/

https://reviews.llvm.org/D143962