[libcxx-commits] [PATCH] D143962: [libc++][NFC] Replace _LIBCPP_STD_VER > x with _LIBCPP_STD_VER >= x
Joe Loser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Feb 13 16:35:32 PST 2023
jloser added inline comments.
================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:286
"headers": ["new"],
"test_suite_guard": "TEST_STD_VER > 17 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L",
+ "libcxx_guard": "_LIBCPP_STD_VER >= 20 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L",
----------------
Out of curiosity, did we decide (or should we) to do the same for `TEST_STD_VER`? It seems slightly out of place seeing it use `>`. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143962/new/
https://reviews.llvm.org/D143962
More information about the libcxx-commits
mailing list