[libcxx-commits] [libcxx] [libc++] tests with picolibc: add has-complete-fenv feature (PR #74610)

[via libcxx-commits]

EricWF wrote:

Yeah what value does this provide to libC++

On Sat, Dec 9, 2023, 8:16 AM Mark de Wever ***@***.***> wrote:

> ***@***.**** commented on this pull request.
> ------------------------------
>
> In libcxx/utils/libcxx/test/features.py
> <https://github.com/llvm/llvm-project/pull/74610#discussion_r1421419709>:
>
> > @@ -212,6 +212,35 @@ def _getAndroidDeviceApi(cfg):
>            """,
>          ),
>      ),
> +    # Some platform do not provide complete floating point environment.
> +    Feature(
> +        name="has-compolete-fenv",
> +        when=lambda cfg: sourceBuilds(
> +            cfg,
> +            """
> +            #include <fenv.h>
> +
> +            #if !( \
> +                defined FE_DIVBYZERO \
>
> This feels a bit like a maintenance burden, if C adds new macros this need
> to be updated too.
> Since we have not needed this before now I don't feel this solves a
> generic.
> How about adding a comment and an // UNSUPPORTED: pico-lib identifier in
> these two tests instead?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/74610#pullrequestreview-1773697080>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAI7G23ZEK5GTP5CYSPNC4TYIRQDVAVCNFSM6AAAAABAJS2J5SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZTGY4TOMBYGA>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/74610