[libcxx-commits] [libcxx] [libc++] tests with picolibc: add has-complete-fenv feature (PR #74610)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sat Dec 9 05:16:35 PST 2023


================
@@ -212,6 +212,35 @@ def _getAndroidDeviceApi(cfg):
           """,
         ),
     ),
+    # Some platform do not provide complete floating point environment.
+    Feature(
+        name="has-compolete-fenv",
+        when=lambda cfg: sourceBuilds(
+            cfg,
+            """
+            #include <fenv.h>
+
+            #if !( \
+                defined FE_DIVBYZERO \
----------------
mordante wrote:

This feels a bit like a maintenance burden, if C adds new macros this need to be updated too.
Since we have not needed this before now I don't feel this solves a generic.
How about adding a comment and an `// UNSUPPORTED: pico-lib identifier` in these two tests instead?

https://github.com/llvm/llvm-project/pull/74610


More information about the libcxx-commits mailing list