[libcxx-commits] [libcxx] [libc++] Protect the libc++ implementation from CUDA SDK's `__noinline__` macro (PR #73838)

[Dmitri Gribenko via libcxx-commits]

gribozavr wrote:

@philnik777 

> I'm pretty sure there are tests for this kind of thing.

I can't find anything using the pattern `::__attribute`. Could you confirm that it is indeed intentionally supported?

> I think we can avoid the preprocessor problem by having the conditional as `#if !defined(_LIBCPP_CXX03_LANG) || _LICPP_CLANG_VER >= 1700`.

Yes, that indeed works.

> we can remove the macro entirely after the next release branch anyways.

Why? Because the next release will not support compilers that don't support the `[[__gnu__::__noinline__]]` syntax?


https://github.com/llvm/llvm-project/pull/73838