[libcxx-commits] [libcxx] [libc++] Protect the libc++ implementation from CUDA SDK's `__noinline__` macro (PR #73838)
Nikolas Klauser via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Dec 1 09:50:26 PST 2023
philnik777 wrote:
@gribozavr I'm pretty sure there are tests for this kind of thing. Clang has to both expand macros in C++11 attribute and ignore unknown ones. There may not be a test for this specific case, but for the general case I expect tests. I think we can avoid the preprocessor problem by having the conditional as `#if !defined(_LIBCPP_CXX03_LANG) || (defined(_LIBCPP_CLANG_VER) && _LICPP_CLANG_VER >= 1700)`. It's not pretty, but we avoid having another macro we have to push/pop and we can remove the macro entirely after the next release branch anyways.
https://github.com/llvm/llvm-project/pull/73838
More information about the libcxx-commits
mailing list