[libcxx-commits] [PATCH] D158749: [libc++] Implement LWG3464(istream::gcount() can overflow)

Mon Aug 28 10:57:47 PDT 2023

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

In D158749#4621858 <https://reviews.llvm.org/D158749#4621858>, @Mordante wrote:

> In D158749#4619918 <https://reviews.llvm.org/D158749#4619918>, @philnik wrote:
>
>> Shouldn't this be possible to actually test? If not, please add a comment why this change was done.
>
> Do you have a suggestion how to test this. It depends on overflowing `streamsize`. This is an alias of `ptrdiff_t`.

Ah sorry, I missed that. I though it depends the char traits. In that case I'm happy with a short explanation in the commit message. Sorry for the churn.

LGTM with a comment in the commit message.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158749/new/

https://reviews.llvm.org/D158749