[libcxx-commits] [PATCH] D158749: [libc++] Implement LWG3464(istream::gcount() can overflow)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D158749#4619918 <https://reviews.llvm.org/D158749#4619918>, @philnik wrote:

> Shouldn't this be possible to actually test? If not, please add a comment why this change was done.

Do you have a suggestion how to test this. It depends on overflowing `streamsize`. This is an alias of `ptrdiff_t`.

In D158749#4619979 <https://reviews.llvm.org/D158749#4619979>, @yronglin wrote:

> In D158749#4619918 <https://reviews.llvm.org/D158749#4619918>, @philnik wrote:
>
>> Shouldn't this be possible to actually test? If not, please add a comment why this change was done.
>
> Sorry, It may be because I didn't refresh the browser page, so I didn't see the status change to `Request change`. I apologize for that. I'll revert this change to resolve your concerns. I have no idea that how to test this, can you please give some guide? many thanks!

For the future it's possible to address these comments after landing the patch. It was not really needed to revert it. But now let's land if after @philnik is happy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158749/new/

https://reviews.llvm.org/D158749