[libcxx-commits] [PATCH] D158669: [libc++][Modules] locale fails to compile with clang modules when _LIBCPP_LOCALE__L_EXTENSIONS is undefined
Ian Anderson via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Aug 24 11:07:38 PDT 2023
iana added inline comments.
================
Comment at: libcxx/include/__locale_dir/locale_base_api/locale_guard.h:12-13
#include <__config>
-#include <clocale>
+#include <__locale>
----------------
iana wrote:
> ldionne wrote:
> > We still need `<clocale>` because we are using `setlocale(...)` and friends. But we should indeed add `<__locale>` because that is what defines `locale_t` when `libcxx/include/__support/xlocale/__nop_locale_mgmt.h` is used.
> 👍 put `<clocale>` back
and added the comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158669/new/
https://reviews.llvm.org/D158669
More information about the libcxx-commits
mailing list