[libcxx-commits] [PATCH] D158669: [libc++][Modules] locale fails to compile with clang modules when _LIBCPP_LOCALE__L_EXTENSIONS is undefined

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 24 11:06:36 PDT 2023


iana updated this revision to Diff 553202.
iana added a comment.

Add a comment why we're including __locale because it's not obvious


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158669/new/

https://reviews.llvm.org/D158669

Files:
  libcxx/include/__locale_dir/locale_base_api/locale_guard.h


Index: libcxx/include/__locale_dir/locale_base_api/locale_guard.h
===================================================================
--- libcxx/include/__locale_dir/locale_base_api/locale_guard.h
+++ libcxx/include/__locale_dir/locale_base_api/locale_guard.h
@@ -10,6 +10,7 @@
 #define _LIBCPP___LOCALE_LOCALE_BASE_API_LOCALE_GUARD_H
 
 #include <__config>
+#include <__locale> // for locale_t
 #include <clocale>
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158669.553202.patch
Type: text/x-patch
Size: 468 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230824/d4e4e220/attachment.bin>


More information about the libcxx-commits mailing list