[libcxx-commits] [PATCH] D158199: [libc++] Fixes disabling wide character.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/include/cstdlib:139
+#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
 using ::mblen _LIBCPP_USING_IF_EXISTS;
 using ::mbtowc _LIBCPP_USING_IF_EXISTS;
----------------
philnik wrote:
> This doesn't seem to require `wchar_t`.
Good catch!


================
Comment at: libcxx/include/iosfwd:124-126
+#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
 typedef fpos<mbstate_t>    wstreampos;
+#endif
----------------
philnik wrote:
> This also doesn't use `wchar_t`.
This is strictly true, but I still think this should be disabled. It's clearly intended for `wchar_t`. The same is done for `char8_t` below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158199/new/

https://reviews.llvm.org/D158199