[libcxx-commits] [PATCH] D158199: [libc++] Fixes disabling wide character.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

Maybe I'm missing something, but it looks to me like you are disabling too many symbols here.



================
Comment at: libcxx/include/cstdlib:139
+#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
 using ::mblen _LIBCPP_USING_IF_EXISTS;
 using ::mbtowc _LIBCPP_USING_IF_EXISTS;
----------------
This doesn't seem to require `wchar_t`.


================
Comment at: libcxx/include/iosfwd:124-126
+#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
 typedef fpos<mbstate_t>    wstreampos;
+#endif
----------------
This also doesn't use `wchar_t`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158199/new/

https://reviews.llvm.org/D158199