[libcxx-commits] [PATCH] D157602: [libc++] Work around dynamic linking of stringstream::str() on Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D157602#4580154 <https://reviews.llvm.org/D157602#4580154>, @thakis wrote:

> @hans Hmm, I wonder if it's related to /Zc:dllexportInlines- (ref https://blog.llvm.org/2018/11/30-faster-windows-builds-with-clang-cl_14.html). We use that, and we build libc++ with -std=c++20 (since it wants that), and we built the client code that had problems with -std=c++17.

Right, this rings some bells.

I ran into similar issues before - see b048397db8027fedf9380e7cf9213239d558fa29 <https://reviews.llvm.org/rGb048397db8027fedf9380e7cf9213239d558fa29> / https://reviews.llvm.org/D122718, for an issue caused by the fact that in the default config, the library is built with `-std=c++20` but the tests are compiled with `-std=c++2b`. I guess we ideally should test with running the tests for a few c++ versions at least, to check for more instances of this issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157602/new/

https://reviews.llvm.org/D157602