[libcxx-commits] [PATCH] D157602: [libc++] Work around dynamic linking of stringstream::str() on Windows

Piotr Fusik via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 11 13:36:35 PDT 2023


pfusik added a comment.

> Can you post the one you tried as starting point? I'll try to tweak it then.



  C:\0\src\llvm-project>git co 090996~1
  HEAD is now at 1e22873ef4b2 [AMDGPU][NFC] Rename two LIT test files
  
  C:\0\src\llvm-project>ninja -C build cxx
  ninja: Entering directory `build'
  ninja: no work to do.
  
  C:\0\src\llvm-project>cd ..
  
  C:\0\src>cat strwin.cpp
  #include <iostream>
  #include <sstream>
  
  int main() {
    std::cout << std::stringstream("hi").str();
  }
  
  C:\0\src>clang++ -std=c++11 -fuse-ld=ld -o strwin.exe strwin.cpp -nostdinc++ -I llvm-project/build/include/c++/v1 llvm-project/build/lib/libc++.dll.a
  
  C:\0\src>.\strwin.exe
  hi

> @pfusik can you make a backport request or do you need assistance?

My only concern is that we have no test. What's the schedule for the next 17.0 RC ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157602/new/

https://reviews.llvm.org/D157602



More information about the libcxx-commits mailing list