[libcxx-commits] [PATCH] D157364: [libc++][Modules] Generate the __std_clang_module header

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 11 09:12:42 PDT 2023


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks for the improvement, this really helps to reduce the maintenance when adding new headers. We don't do it often so more automation is really nice to have.

LGTM!



================
Comment at: libcxx/utils/generate_std_clang_module_header.py:60
+    # Include the angle brackets in sorting so that <a.h> sorts before <a>
+    # like check-format wants.
+    for include in sorted([f"<{header}>" for header in always_available_headers]):
----------------
Great comment, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157364/new/

https://reviews.llvm.org/D157364



More information about the libcxx-commits mailing list