[libcxx-commits] [PATCH] D157364: [libc++][Modules] Generate the __std_clang_module header

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 10 21:15:22 PDT 2023


iana added inline comments.


================
Comment at: libcxx/utils/libcxx/header_information.py:61
+header_include_requirements = {
+    ("_LIBCPP_HAS_NO_ATOMIC_HEADER",): (
+        # headers with #error directives
----------------
The module map requires and `lit_header_restrictions` looked like there were going to be headers that had multiple requirements, which is why the key is requirement tuples. But it turned out that all the headers only have one requirement. Should I keep the tuple keys and support for multiples in the script, or just make the keys strings?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157364/new/

https://reviews.llvm.org/D157364



More information about the libcxx-commits mailing list