[libcxx-commits] [PATCH] D157364: [libc++][Modules] Generate the __std_clang_module header

[Ian Anderson via Phabricator via libcxx-commits]

iana marked 5 inline comments as done.
iana added inline comments.


================
Comment at: libcxx/utils/generate_std_clang_module_header.py:47
+    )
+    for header in sorted(always_available_headers):
+        std_clang_module_header.write("#include <")
----------------
Mordante wrote:
> The format script complains about the sorting, mainly hunks like
> ```
> -#include <limits>
>  #include <limits.h>
> +#include <limits>
> ```
> I suspect this is something what happens on Apple where the ordering of `.` and '>` differs. I know that @ldionne has seen this too. Would it help to force the C locale? This is something we use in other places where we sort data in the CI.
It's because it's only sorting the header names, i.e. it has "limits.h" and "limits", it doesn't have "<limits.h>" and "<limits>".


================
Comment at: libcxx/utils/generate_std_clang_module_header.py:48-50
+        std_clang_module_header.write("#include <")
+        std_clang_module_header.write(header)
+        std_clang_module_header.write(">\n")
----------------
Mordante wrote:
> I feel this is a bit more readable, can you look at using f-strings at other places too.
Sure


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157364/new/

https://reviews.llvm.org/D157364