[libcxx-commits] [PATCH] D157364: [libc++][Modules] Generate the __std_clang_module header

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 10 11:24:25 PDT 2023


iana marked 3 inline comments as done.
iana added inline comments.


================
Comment at: libcxx/test/libcxx/assertions/headers_declare_verbose_abort.gen.py:17
 sys.path.append(sys.argv[1])
-from libcxx.test.header_information import lit_header_restrictions, public_headers
+from libcxx.header_information import lit_header_restrictions, public_headers
 
----------------
Mordante wrote:
> I would like to see this change and its related changes in a separate review.
https://reviews.llvm.org/D157639


================
Comment at: libcxx/utils/libcxx/header_information.py:18-21
-    "experimental/algorithm": "// UNSUPPORTED: c++03",
     "experimental/deque": "// UNSUPPORTED: c++03",
     "experimental/forward_list": "// UNSUPPORTED: c++03",
-    "experimental/functional": "// UNSUPPORTED: c++03",
----------------
Mordante wrote:
> I would like to see these two changes committed separately. When the CI is green feel free to commit these two.
I put them in https://reviews.llvm.org/D157639, is that ok or should I make one more review?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157364/new/

https://reviews.llvm.org/D157364



More information about the libcxx-commits mailing list