[libcxx-commits] [PATCH] D157569: Fixed issue #64544 ([libc++] std::rotl and std::rotr have the wrong signature)

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 10 10:00:55 PDT 2023


philnik added inline comments.


================
Comment at: libcxx/include/__bit/rotate.h:42
-
-  if (__cnt < 0)
-    return std::__rotr(__t, -__cnt);
----------------
It looks like your patch is missing the last commit. I'd recommend squashing the two into one and upload the resulting patch again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157569/new/

https://reviews.llvm.org/D157569



More information about the libcxx-commits mailing list