[libcxx-commits] [PATCH] D157569: Fixed issue #64544 ([libc++] std::rotl and std::rotr have the wrong signature)

Danny via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 9 22:12:59 PDT 2023


DKay7 updated this revision to Diff 548876.
DKay7 added a comment.

- Added unit-tests for `std::rotr` and `std::rorl` with negative values.
- Rewrited `std::__rotr` as @philnik asked.
- Rewrited `std::rotr` and `std::rorl` via new `std::__rotr`, but not sure if new implementations are not confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157569/new/

https://reviews.llvm.org/D157569

Files:
  libcxx/include/__bit/rotate.h
  libcxx/test/std/numerics/bit/bitops.rot/rotl.pass.cpp
  libcxx/test/std/numerics/bit/bitops.rot/rotr.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157569.548876.patch
Type: text/x-patch
Size: 6055 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230810/be026f00/attachment.bin>


More information about the libcxx-commits mailing list