[libcxx-commits] [PATCH] D157364: [libc++][Modules] Generate the __std_clang_module header

[Ian Anderson via Phabricator via libcxx-commits]

iana added inline comments.


================
Comment at: libcxx/docs/Contributing.rst:55
 - Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it?
 - Did you run the ``libcxx-generate-files`` target and verify its output?
 
----------------
Mordante wrote:
> Typically our generated files are stored in git and manually regenerated. This makes it easier to track changes.
> 
> The 'generated output` CI job regenerated the file and complains when a difference happens.
Are you saying this should move to the `libcxx-generate-files` target? Or it should be a static file that we have to remember to manually regenerate when we add/remove public headers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157364/new/

https://reviews.llvm.org/D157364