[libcxx-commits] [PATCH] D157364: [libc++][Modules] Generate the __std_clang_module header

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 8 11:43:34 PDT 2023


Mordante added a comment.

Thanks for working on this! I see several not related changes, for now let's keep them but land them separately.

I would like to see a slightly different design before reviewing in-depth.



================
Comment at: libcxx/docs/Contributing.rst:55
 - Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it?
 - Did you run the ``libcxx-generate-files`` target and verify its output?
 
----------------
Typically our generated files are stored in git and manually regenerated. This makes it easier to track changes.

The 'generated output` CI job regenerated the file and complains when a difference happens.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157364/new/

https://reviews.llvm.org/D157364



More information about the libcxx-commits mailing list