[libcxx-commits] [PATCH] D148831: [libc++] Adds newer clang-tidy in the CI.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 27 08:22:04 PDT 2023


Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/utils/ci/Dockerfile:87
 # Install clang-tidy
-RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 2)) clang-tidy-$((LLVM_HEAD_VERSION - 1))
+# TODO LLVM 18 only install $(($LLVM_HEAD_VERSION - 1)) and $LLVM_HEAD_VERSION
+RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 2)) clang-tidy-$(($LLVM_HEAD_VERSION - 1)) clang-tidy-$LLVM_HEAD_VERSION
----------------
ldionne wrote:
> 
I uses slightly different wording and referred to this review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148831/new/

https://reviews.llvm.org/D148831



More information about the libcxx-commits mailing list