[libcxx-commits] [PATCH] D148831: [libc++] Adds newer clang-tidy in the CI.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but I think we should revert this patch to use the stable clang-tidy again once it supports the features you need for Modules. We had decided to use the stable clang-tidy to make sure CI issues were easily reproducible.



================
Comment at: libcxx/utils/ci/Dockerfile:87
 # Install clang-tidy
-RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 2)) clang-tidy-$((LLVM_HEAD_VERSION - 1))
+# TODO LLVM 18 only install $(($LLVM_HEAD_VERSION - 1)) and $LLVM_HEAD_VERSION
+RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 2)) clang-tidy-$(($LLVM_HEAD_VERSION - 1)) clang-tidy-$LLVM_HEAD_VERSION
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148831/new/

https://reviews.llvm.org/D148831