[libcxx-commits] [PATCH] D132310: [libc++][regex] Uses operator<=> in sub_match.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/test/std/re/re.submatch/re.submatch.op/compare.pass.cpp:300-301
+// It has a comparison_category used in the tests.
+template <class CharT, class Ordering>
+struct char_traits {
+    using char_type           = CharT;
----------------
ldionne wrote:
> Could you do this instead to reduce the boilerplate?
> 
> ```
> template <class CharT, class Ordering>
> struct char_traits : constexpr_char_traits {
>     using comparison_category = Ordering;
> };
> ```
Thanks for the suggestion, this looks a lot better!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132310/new/

https://reviews.llvm.org/D132310