[libcxx-commits] [PATCH] D132310: [libc++][regex] Uses operator<=> in sub_match.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Apr 20 09:15:49 PDT 2023
ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.
================
Comment at: libcxx/test/std/re/re.submatch/re.submatch.op/compare.pass.cpp:300-301
+// It has a comparison_category used in the tests.
+template <class CharT, class Ordering>
+struct char_traits {
+ using char_type = CharT;
----------------
Could you do this instead to reduce the boilerplate?
```
template <class CharT, class Ordering>
struct char_traits : constexpr_char_traits {
using comparison_category = Ordering;
};
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132310/new/
https://reviews.llvm.org/D132310
More information about the libcxx-commits
mailing list