[libcxx-commits] [PATCH] D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/src/std_stream.h:66
+#else
+    inline static constexpr bool __is_win32api_wide_char = false;
+#endif
----------------
mstorsjo wrote:
> Mordante wrote:
> > I actually intended it not to be in the class. I don't mind it, but then we don't need the inline.
> Yeah, it looked like that, but I wasn’t sure of how that’d work with the template parameter `CharT` - wouldn’t I need to pass it on from each of the class templates to the template bool variable then? (This is a bit outside of the C++ template syntax I’m proficient about…)
Yes then you needed to pass them in `if constexpr`. But this in fine too (modulo the inline).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146398/new/

https://reviews.llvm.org/D146398