[libcxx-commits] [PATCH] D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/src/std_stream.h:66
+#else
+    inline static constexpr bool __is_win32api_wide_char = false;
+#endif
----------------
Mordante wrote:
> I actually intended it not to be in the class. I don't mind it, but then we don't need the inline.
Yeah, it looked like that, but I wasn’t sure of how that’d work with the template parameter `CharT` - wouldn’t I need to pass it on from each of the class templates to the template bool variable then? (This is a bit outside of the C++ template syntax I’m proficient about…)


================
Comment at: libcxx/test/std/input.output/iostream.objects/wide.stream.objects/check-stderr.sh:1
+program=${1}
+expected_file=${2}
----------------
Mordante wrote:
> Can you add some comments to these test explaining what they do.
Sure, can do. (These are copies of similar scripts in one directory above, but these take the reference from a file - which in this case is written as UCS2/UTF16 - while the existing test scripts take the reference string as a command line parameter.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146398/new/

https://reviews.llvm.org/D146398