[libcxx-commits] [PATCH] D148478: [libc++][PSTL] Add design docs

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D148478#4272963 <https://reviews.llvm.org/D148478#4272963>, @grandinj wrote:

> Would be nice to include
>
> (a) the unabbreviated form of PSTL

This is a bit ambiguous. Do you mean "Parallel STL"? If yes, I'm not sure it results in less confusion, since it's mostly referred to as the PSTL. The subdirectory is also called `pstl`.

> (b) a link to the project

Where exactly would you like to have a link to? AFAIK there is no website for the LLVM PSTL, and linking to the Intel PSTL would be a bit confusing IMO.

> I had to google it to figure out what this note was about :-)





================
Comment at: libcxx/docs/DesignDocs/PSTL.rst:9-10
+
+- No ``<__pstl_algorithm>`` and similar glue headers -- instead, the implementation files are included directly in
+  ``<algorithm>`` and friends.
+- No ``<pstl/internal/algorithm_impl.h>`` and ``<pstl/internal/algorithm_fwd.h>`` headers and friends -- these contain
----------------
Mordante wrote:
> In a design documentation I expect some information behind the design choices. Can you add that information.
The reason for basically all of the removals is "we don't need the flexibility that the extra complexity provides, but we have to modify the code to fit our needs". Do you have any wording suggestions?


================
Comment at: libcxx/docs/DesignDocs/PSTL.rst:20
+  is done inside ``__config_site.in`` and ``__config`` respectively.
+- libc++-style tests for the public PSTL API
----------------
Mordante wrote:
> Maybe the document should contain some information on how we intend to keep in sync with upstream.
We can add that once we know how we will do that. Right now the only plan is to have matching patches for libc++. The PSTL isn't exactly active.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148478/new/

https://reviews.llvm.org/D148478