[libcxx-commits] [PATCH] D148478: [libc++][PSTL] Add design docs
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Apr 17 08:48:42 PDT 2023
Mordante added a comment.
Thanks for writing the documentation! Some remarks.
In D148478#4272963 <https://reviews.llvm.org/D148478#4272963>, @grandinj wrote:
> Would be nice to include
>
> (a) the unabbreviated form of PSTL
> and
> (b) a link to the project
+1
================
Comment at: libcxx/docs/DesignDocs/PSTL.rst:5
+
+The PSTL project is quite complex in it's current form and does not provide everything that libc++ requires, for example
+``_LIBCPP_HIDE_FROM_ABI`` or similar annotations and including granularized headers. Because of these drawbacks, we
----------------
================
Comment at: libcxx/docs/DesignDocs/PSTL.rst:9-10
+
+- No ``<__pstl_algorithm>`` and similar glue headers -- instead, the implementation files are included directly in
+ ``<algorithm>`` and friends.
+- No ``<pstl/internal/algorithm_impl.h>`` and ``<pstl/internal/algorithm_fwd.h>`` headers and friends -- these contain
----------------
In a design documentation I expect some information behind the design choices. Can you add that information.
================
Comment at: libcxx/docs/DesignDocs/PSTL.rst:20
+ is done inside ``__config_site.in`` and ``__config`` respectively.
+- libc++-style tests for the public PSTL API
----------------
Maybe the document should contain some information on how we intend to keep in sync with upstream.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148478/new/
https://reviews.llvm.org/D148478
More information about the libcxx-commits
mailing list