[libcxx-commits] [PATCH] D147880: [libc++][format] Mark range formaters as complete.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:340-341
     "headers": ["stacktrace", "thread"],
     "test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)",
     "libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)",
     "unimplemented": True,
----------------
ldionne wrote:
> These ones should also be updated to just `!defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)`. I think you created the patch that added this before I changed `__availability`.
Yes and since there were no merge conflicts there was no notification of the issue. But at least good we spotted it during review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147880/new/

https://reviews.llvm.org/D147880