[libcxx-commits] [PATCH] D147880: [libc++][format] Mark range formaters as complete.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 11 08:57:50 PDT 2023
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM w/ changes!
================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:334-335
+ "headers": ["format"],
+ "test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)",
+ "libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)",
}, {
----------------
If you rebase onto `main`, I think what you want here is just `!defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)`.
================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:340-341
"headers": ["stacktrace", "thread"],
"test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)",
"libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)",
"unimplemented": True,
----------------
These ones should also be updated to just `!defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)`. I think you created the patch that added this before I changed `__availability`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147880/new/
https://reviews.llvm.org/D147880
More information about the libcxx-commits
mailing list